fix(concat): correct xfade offset calculation for variable transition durations - #7
Merged
Conversation
… durations
Bug: offset = cum_duration - trans_duration * i
This assumed all transitions have the same duration. When a later
transition duration increased (e.g., 0.4 -> 0.5), trans_duration*i
could grow faster than cum_duration, causing negative offset regression.
Example from rsi_cn timeline:
i=38 offset=520.58 (td=0.4)
i=39 offset=519.66 (td=0.5) ← regression!
Fix: offset = cum_duration - sum(all_transition_durations[:i])
Each transition's actual duration is now accumulated individually.
Verified: all 48 offsets are monotonically increasing after fix.
Closes: concat-engine-offset-regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ffmpeg filter_complex failure caused by offset regression when transition durations vary across clips.